<html>
<head><meta charset="utf-8"><title>uploading perf measurements · t-compiler/wg-rfc-2229 · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/index.html">t-compiler/wg-rfc-2229</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html">uploading perf measurements</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="242632881"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/242632881" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#242632881">(Jun 14 2021 at 17:31)</a>:</h4>
<p>It would be fairly easy to make a google form where they can upload perf measurements</p>



<a name="243488666"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/243488666" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#243488666">(Jun 22 2021 at 09:00)</a>:</h4>
<p>Is there a unique id across the compiler for each compiler?</p>
<p>I was trying to get dumping closure data into csv working, but right now I'm printing each time a closure is monomorphised.</p>
<p>There are a couple options, but I'm not sure how to work them in the compiler:</p>
<ul>
<li>Either we generate a static file name eg: closure_size_profile.csv. This would require erasing any existng  file at the start of each compiler</li>
<li>Have a somewhat random name be generated at the start of the compiler eg: closure_size_profile_random_uuid.csv and then we started in Session or some global state</li>
<li>Collect instances being monomorphised and then profile them all at once (there is some collection happening, but I"m not quite sure if everything we want is there and what's the best spot to dump data out)</li>
</ul>



<a name="243526828"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/243526828" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#243526828">(Jun 22 2021 at 14:42)</a>:</h4>
<p>I don't think there's a unique identifier of that kind, but there might be. <span class="user-mention" data-user-id="124287">@mw</span> might know.</p>



<a name="243616792"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/243616792" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#243616792">(Jun 23 2021 at 07:44)</a>:</h4>
<p>Can you give me a bit more context?</p>



<a name="243619165"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/243619165" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#243619165">(Jun 23 2021 at 08:10)</a>:</h4>
<p>I'm trying to output information about closure size so that we can profile the effect of RFC 2229.</p>
<p>The data in compute in rustc_mir/monomorph/collector so that we can account for generics.</p>
<p>I'm trying to avoid having to collect this information and dump it at once into a file. </p>
<p>I was hoping that if there was some id unique a compile I can just create a file <code>closure_profile_{id}.csv</code> that I just dump information into</p>



<a name="243620839"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/243620839" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#243620839">(Jun 23 2021 at 08:27)</a>:</h4>
<p>It depends on what the requirements for that ID are. For self-profiling (for example) we just generate a file name that contains the crate name and the compiler's process id: <a href="https://github.com/rust-lang/rust/blob/8cb207ae69700de3e782eec5cc9013c0987b2519/compiler/rustc_data_structures/src/profiling.rs#L403-L405">https://github.com/rust-lang/rust/blob/8cb207ae69700de3e782eec5cc9013c0987b2519/compiler/rustc_data_structures/src/profiling.rs#L403-L405</a></p>



<a name="243620922"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/243620922" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#243620922">(Jun 23 2021 at 08:28)</a>:</h4>
<p>that should make it pretty unlikely that two compilation processes interfere</p>



<a name="243620933"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/243620933" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#243620933">(Jun 23 2021 at 08:28)</a>:</h4>
<p>you could also add a time-stamp</p>



<a name="243621173"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/243621173" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#243621173">(Jun 23 2021 at 08:31)</a>:</h4>
<p>If you have the <code>tcx</code> available you can use <code>tcx.crate_name(LOCAL_CRATE)</code> to easily get the crate name.</p>



<a name="243621178"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/243621178" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#243621178">(Jun 23 2021 at 08:31)</a>:</h4>
<p><span class="user-mention silent" data-user-id="124287">mw</span> <a href="#narrow/stream/189812-t-compiler.2Fwg-rfc-2229/topic/uploading.20perf.20measurements/near/243620839">said</a>:</p>
<blockquote>
<p>It depends on what the requirements for that ID are. For self-profiling (for example) we just generate a file name that contains the crate name and the compiler's process id: <a href="https://github.com/rust-lang/rust/blob/8cb207ae69700de3e782eec5cc9013c0987b2519/compiler/rustc_data_structures/src/profiling.rs#L403-L405">https://github.com/rust-lang/rust/blob/8cb207ae69700de3e782eec5cc9013c0987b2519/compiler/rustc_data_structures/src/profiling.rs#L403-L405</a></p>
</blockquote>
<p>Okay this is kind of what i was thinking of, thank you</p>



<a name="243621216"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/243621216" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#243621216">(Jun 23 2021 at 08:31)</a>:</h4>
<p>you're welcome <code>:)</code></p>



<a name="244207871"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244207871" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244207871">(Jun 28 2021 at 21:37)</a>:</h4>
<p>Does it make sense to do some computation directly in the compiler and output that in the CSV eg: change and %change. <br>
This would mean when we get the CSV from the user we would've to just put that in a template and it will directly generate the metrics</p>



<a name="244208003"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244208003" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244208003">(Jun 28 2021 at 21:38)</a>:</h4>
<p>It's possible that I don't know google sheets enough and there is a way to just compute change and %change per row of the data, but making the compiler do it seems simpler</p>



<a name="244357383"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244357383" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244357383">(Jun 29 2021 at 22:38)</a>:</h4>
<p><span class="user-mention silent" data-user-id="281950">Aman Arora</span> <a href="#narrow/stream/189812-t-compiler.2Fwg-rfc-2229/topic/uploading.20perf.20measurements/near/244208003">said</a>:</p>
<blockquote>
<p>It's possible that I don't know google sheets enough and there is a way to just compute change and %change per row of the data, but making the compiler do it seems simpler</p>
</blockquote>
<p>that is quite easy to do</p>



<a name="244357391"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244357391" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244357391">(Jun 29 2021 at 22:38)</a>:</h4>
<p>but it'll be easier in the compiler in the end</p>



<a name="244357402"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244357402" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244357402">(Jun 29 2021 at 22:38)</a>:</h4>
<p>than to do it on each person's spreadsheet</p>



<a name="244358141"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244358141" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244358141">(Jun 29 2021 at 22:47)</a>:</h4>
<p><a href="https://docs.google.com/spreadsheets/d/1WUKERwkpJkYhQ-rt0aTQqg-7kcupC7pwKsgxk8v54qc/edit#gid=1571025214">https://docs.google.com/spreadsheets/d/1WUKERwkpJkYhQ-rt0aTQqg-7kcupC7pwKsgxk8v54qc/edit#gid=1571025214</a></p>



<a name="244358159"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244358159" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244358159">(Jun 29 2021 at 22:48)</a>:</h4>
<p>So this is what i ended up doing</p>



<a name="244358309"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244358309" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244358309">(Jun 29 2021 at 22:49)</a>:</h4>
<p>As long as there are 22k closures, we can import the user's uploaded csv in thre first sheet</p>



<a name="244358377"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244358377" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244358377">(Jun 29 2021 at 22:50)</a>:</h4>
<p>tried this on cargo: <a href="https://docs.google.com/spreadsheets/d/1ewerI7G0TcDAveyOMaW6pN0kZQPhY84JL0nuUnc2vhs/edit#gid=700101355">https://docs.google.com/spreadsheets/d/1ewerI7G0TcDAveyOMaW6pN0kZQPhY84JL0nuUnc2vhs/edit#gid=700101355</a></p>



<a name="244360738"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244360738" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244360738">(Jun 29 2021 at 23:15)</a>:</h4>
<p>So I created this google form: <a href="https://forms.gle/4NXVZDpPwQf8brSEA">https://forms.gle/4NXVZDpPwQf8brSEA</a>. Unfortunately if you use file upload, Google will record the name and email of the person submitting the form</p>



<a name="244361807"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244361807" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244361807">(Jun 29 2021 at 23:29)</a>:</h4>
<p>I think that's ok</p>



<a name="244361817"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244361817" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244361817">(Jun 29 2021 at 23:29)</a>:</h4>
<p>we just have to be up front with it</p>



<a name="244361829"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244361829" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244361829">(Jun 29 2021 at 23:29)</a>:</h4>
<p>Google form let's the user know of that</p>



<a name="244361843"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244361843" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244361843">(Jun 29 2021 at 23:29)</a>:</h4>
<p>I think MS forms only collects names and not emails, so might be better, I'm trying that out</p>



<a name="244362071"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244362071" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rocksand <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244362071">(Jun 29 2021 at 23:33)</a>:</h4>
<p><span class="user-mention" data-user-id="281950">@Aman Arora</span>  I think it may also be good to state explicitly on the form who would have access to the submitted data</p>



<a name="244362156"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244362156" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244362156">(Jun 29 2021 at 23:34)</a>:</h4>
<p>Hmm I'm not sure if we will be restricting it to just 2229 wg, I am assuming it t-perf and t-compiler will also be interested in this data.</p>



<a name="244362161"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244362161" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244362161">(Jun 29 2021 at 23:34)</a>:</h4>
<p>The profiling data collected by the compiler contains the names of files in your project, and might contain identifiable information. Also note that this data will be accessed by members of the Rust community. Please acknowledge that you're aware of this!</p>



<a name="244362183"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244362183" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244362183">(Jun 29 2021 at 23:34)</a>:</h4>
<p>Idk if saying "Rust community" is too vague or just good enough to say many people might have access to this</p>



<a name="244362294"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244362294" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244362294">(Jun 29 2021 at 23:37)</a>:</h4>
<p>I would say "be aware that this data may be shared with rust members and contributors"</p>



<a name="244362302"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244362302" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244362302">(Jun 29 2021 at 23:37)</a>:</h4>
<p>Okay thank you</p>



<a name="244362304"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244362304" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244362304">(Jun 29 2021 at 23:37)</a>:</h4>
<p>that's pretty vague, but I think conveys that we wouldn't publish it for anyone to download</p>



<a name="244362312"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244362312" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244362312">(Jun 29 2021 at 23:37)</a>:</h4>
<p>(also, I'm looking at the stats you included in your PR-- those look great!)</p>



<a name="244362320"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244362320" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244362320">(Jun 29 2021 at 23:37)</a>:</h4>
<p><span aria-label="grinning" class="emoji emoji-1f600" role="img" title="grinning">:grinning:</span></p>



<a name="244362382"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244362382" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244362382">(Jun 29 2021 at 23:38)</a>:</h4>
<p>The optimization had a much nicer impact than what I was hoping  for</p>



<a name="244362529"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244362529" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244362529">(Jun 29 2021 at 23:41)</a>:</h4>
<p>Another interesting thing to note is that the compiler profile is over a lot of crates, and what really comes down to is many crates are now at near 0% affected. <code>syn</code> from what I understand was competely back to original closure size</p>



<a name="244434098"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244434098" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244434098">(Jun 30 2021 at 14:43)</a>:</h4>
<p>that's fantastic</p>



<a name="244741681"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/uploading%20perf%20measurements/near/244741681" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/uploading.20perf.20measurements.html#244741681">(Jul 02 2021 at 18:34)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span>  I realized that the profile closures flag doesn't work as expected if the feature is enabled. I have created a fixup PR here: <a href="https://github.com/rust-lang/rust/pull/86818">https://github.com/rust-lang/rust/pull/86818</a>.</p>
<p>Do you think we should talk about this flag and optimization someone can make based on the profile in the edition guide? I have what i was thinking written down here: <a href="https://github.com/rust-lang/edition-guide/pull/246#discussion_r663139817">https://github.com/rust-lang/edition-guide/pull/246#discussion_r663139817</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>